[Tests] Deduplicate shared test case names#30
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR deduplicates test case names by introducing shared constants in safe_conversion_test.go. Previously, identical string literals like "zero value", "positive value", and "max uint32" were repeated across multiple table-driven tests.
- Introduced 14 shared constants for common test case names
- Replaced all hardcoded string literals with the corresponding constants across 20+ test functions
- Maintained identical test behavior while improving maintainability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
github-actions
Bot
added
feature
github-actions
Bot
deleted the
feat/fix-issues-and-run-linter-tests-s38zyp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
safe_conversion_test.goWhy It Was Necessary
Testing Performed
golangci-lint rungo test ./...Impact / Risk
https://chatgpt.com/codex/tasks/task_e_68e81bfe5a588321b70cbfcc13455b01